[ 
https://issues.apache.org/jira/browse/YARN-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342879#comment-15342879
 ] 

Junping Du edited comment on YARN-5266 at 6/21/16 10:19 PM:
------------------------------------------------------------

Hi [~xgong], thanks for the patch. The 2nd patch looks mostly OK. 
Just naming issues:
dumpAContainersLogsForALogType => dumpAContainerLogsForLogType (remove 's' 
after container, better to remove 'A' as well)
dumpAContainersLogsForALogTypeWithoutNodeId (same reason as above).
The test failure issue in TestLogsCLI should be fixed already. TestYarnClient 
is irrelevant.


was (Author: djp):
Hi [~xgong], thanks for the patch. The 2nd patch looks mostly OK. 
Just naming issues:
dumpAContainersLogsForALogType => dumpAContainerLogsForLogType (remove 's' 
after container, better to remove 'A' as well)
dumpAContainersLogsForALogTypeWithoutNodeId (remove 's' after container, better 
to remove 'A' as well).
The test failure issue in TestLogsCLI should be fixed already. TestYarnClient 
is irrelevant.

> Wrong exit code while trying to get app logs using regex via CLI
> ----------------------------------------------------------------
>
>                 Key: YARN-5266
>                 URL: https://issues.apache.org/jira/browse/YARN-5266
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 2.9.0
>            Reporter: Sumana Sathish
>            Assignee: Xuan Gong
>            Priority: Critical
>         Attachments: YARN-5266.1.patch, YARN-5266.2.patch
>
>
> The test is trying to do negative test by passing regex as 'ds+' and expects 
> exit code != 0.
> *Exit Code is zero and the error message is typed more than once*
> {code}
> RUNNING: /usr/hdp/current/hadoop-yarn-client/bin/yarn  logs -applicationId 
> application_1465500362360_0016 -logFiles ds+
> Can not find any log file matching the pattern: [ds+] for the application: 
> application_1465500362360_0016
> 2016-06-14 
> 19:19:25,079|beaver.machine|INFO|4427|140145752217344|MainThread|Can not find 
> any log file matching the pattern: [ds+] for the application: 
> application_1465500362360_0016
> 2016-06-14 
> 19:19:25,216|beaver.machine|INFO|4427|140145752217344|MainThread|Can not find 
> any log file matching the pattern: [ds+] for the application: 
> application_1465500362360_0016
> 2016-06-14 
> 19:19:25,331|beaver.machine|INFO|4427|140145752217344|MainThread|Can not find 
> any log file matching the pattern: [ds+] for the application: 
> application_1465500362360_0016
> 2016-06-14 
> 19:19:25,432|beaver.machine|INFO|4427|140145752217344|MainThread|Can not find 
> any log file matching the pattern: [ds+] for the application: 
> application_1465500362360_0016
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to