[ https://issues.apache.org/jira/browse/YARN-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355661#comment-15355661 ]
Akira Ajisaka commented on YARN-5159: ------------------------------------- Mostly looks good to me. Would you fix the checkstyle warning? {noformat} ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java:740: * @throws InterruptedException if any thread has interrupted the current thread.: Line is longer than 80 characters (found 83). {noformat} I'm +1 if that is addressed. > Wrong Javadoc tag in MiniYarnCluster > ------------------------------------ > > Key: YARN-5159 > URL: https://issues.apache.org/jira/browse/YARN-5159 > Project: Hadoop YARN > Issue Type: Test > Components: timelineserver > Affects Versions: 2.6.0 > Reporter: Andras Bokor > Assignee: Andras Bokor > Priority: Minor > Fix For: 2.8.0 > > Attachments: YARN-5159.01.patch > > > {@YarnConfiguration.RM_SCHEDULER_INCLUDE_PORT_IN_NODE_NAME} is wrong. Should > be changed to > {@value YarnConfiguration#RM_SCHEDULER_INCLUDE_PORT_IN_NODE_NAME} > Edit: > I noted that due to java 8 javadoc restrictions the javadoc:test-javadoc goal > fails on hadoop-yarn-server-tests project. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org