[ 
https://issues.apache.org/jira/browse/YARN-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364676#comment-15364676
 ] 

Jian He commented on YARN-5233:
-------------------------------

minor comment:
this logic could be simplified to throw exception directly.
{code}
      } catch (Exception e) {
        LOG.warn("Error loading plugin " + name, e);
        caught = e;
      }

      if (cacheIdPlugin == null) {
        throw new RuntimeException("No class defined for " + name, caught);
      }
{code}
One question is that the customClassLoader should be able to load regular 
plugin class too ?

> Support for specifying a path for ATS plugin jars
> -------------------------------------------------
>
>                 Key: YARN-5233
>                 URL: https://issues.apache.org/jira/browse/YARN-5233
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: 2.8.0
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-5233-trunk.001.patch, YARN-5233-trunk.002.patch
>
>
> Third-party plugins need to add their jars to ATS. Most of the times, 
> isolation is not needed. However, there needs to be a way to specify the 
> path. For now, the jars on that path can be added to default classloader.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to