[ 
https://issues.apache.org/jira/browse/YARN-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369096#comment-15369096
 ] 

sandflee commented on YARN-5318:
--------------------------------

thanks [~varun_saxena], yes, to this issue, scheduler process is not required, 
but there are a change that RESOURCE UPDATE event is taken by event handler and 
just before processing it, drainEvents get called and will return, the check 
will be fail. This can happen in theory,and not sure whether it will happen in 
practice, and this is used  just for test, maybe we can ignore this race 
condition.

not related to this patch, I was thinking a more general way to handle test 
failure, some failure are caused by scheduler event processed async, If we had 
to way to drain all RM events and scheduler event, I may help to reduce the 
test fail change. 




> TestRMAdminService#testRefreshNodesResourceWithFileSystemBasedConfigurationProvider
>  fails intermittently.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5318
>                 URL: https://issues.apache.org/jira/browse/YARN-5318
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: sandflee
>            Assignee: Jun Gong
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: YARN-5318.01.patch
>
>
> org.junit.ComparisonFailure: expected:<<memory:[4096, vCores:4]>> but 
> was:<<memory:[5120, vCores:5]>>
>       at org.junit.Assert.assertEquals(Assert.java:115)
>       at org.junit.Assert.assertEquals(Assert.java:144)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRefreshNodesResourceWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:238)
> https://builds.apache.org/job/PreCommit-YARN-Build/12204/testReport/org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager/TestAMRestart/testAMRestartNotLostContainerCompleteMsg/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to