[
https://issues.apache.org/jira/browse/YARN-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369276#comment-15369276
]
Varun Saxena edited comment on YARN-5037 at 7/9/16 8:25 PM:
------------------------------------------------------------
[~sandflee], a nit in the javadoc.
The javadoc above waitForAppRemovedFromScheduler says,
{code}
* @param appId the id of an attempt
{code}
Should be id of an app.
Typecasting to AbstractYarnScheduler may not be correct as some custom
schedulers may not use this class but I see a lot of tests making this
assumption so lets leave it as it is because there is no other way to get hold
of apps in scheduler.
was (Author: varun_saxena):
[~sandflee], a nit in the javadoc.
The javadoc above waitForAppRemovedFromScheduler says,
{code}
* @param appId the id of an attempt
{code}
Should be id of an app.
Typecasting to AbstractYarnScheduler may not be correct as some custom
schedulers may not use this class but I see a lot of tests making this
assumption so lets leave it as it is.
> TestRMRestart#testQueueMetricsOnRMRestart random faiure
> -------------------------------------------------------
>
> Key: YARN-5037
> URL: https://issues.apache.org/jira/browse/YARN-5037
> Project: Hadoop YARN
> Issue Type: Test
> Reporter: sandflee
> Assignee: sandflee
> Attachments: YARN-5037.01.patch, YARN-5037.02.patch,
> YARN-5037.03.patch
>
>
> https://builds.apache.org/job/PreCommit-YARN-Build/11326/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_95.txt
> {noformat}
> Tests run: 28, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 67.159 sec
> <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
> testQueueMetricsOnRMRestart(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart)
> Time elapsed: 2.561 sec <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.assertQueueMetrics(TestRMRestart.java:1874)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testQueueMetricsOnRMRestart(TestRMRestart.java:1849)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
