[ 
https://issues.apache.org/jira/browse/YARN-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372027#comment-15372027
 ] 

Joep Rottinghuis commented on YARN-5354:
----------------------------------------

This should work, but why not use
{code}
  @Rule
  public final TemporaryFolder folder = new TemporaryFolder();
{code}
Or name it timelineV2StorageDir. 
That seems to be the pattern used in my unit test. Has the advantage that you 
don't have to write cleanup code in your tearDown.

> TestDistributedShell.checkTimelineV2() may fail for concurrent tests
> --------------------------------------------------------------------
>
>                 Key: YARN-5354
>                 URL: https://issues.apache.org/jira/browse/YARN-5354
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelineserver
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-5354.01.patch
>
>
> {{TestDistributedShell.checkTimelineV2()}} uses the default (hard-coded) 
> storage root directory. This is brittle against concurrent tests. We should 
> use a unique storage directory for the unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to