[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378279#comment-15378279
]
Karthik Kambatla commented on YARN-5047:
----------------------------------------
Sorry for missing this in my previous review. AbstractYarnScheduler#getNode can
return {{N}} instead of {{SchedulerNode}}. That way, you wouldn't need to
typecast in FifoScheduler. Otherwise, the patch looks good to me.
[~leftnoteasy] - mind taking a look at this, when you get a chance. Would like
to get this in soon to unblock further de-dup work.
> Refactor nodeUpdate across schedulers
> -------------------------------------
>
> Key: YARN-5047
> URL: https://issues.apache.org/jira/browse/YARN-5047
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, fairscheduler, scheduler
> Affects Versions: 3.0.0-alpha1
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Attachments: YARN-5047.001.patch, YARN-5047.002.patch,
> YARN-5047.003.patch, YARN-5047.004.patch, YARN-5047.005.patch
>
>
> FairScheduler#nodeUpdate() and CapacityScheduler#nodeUpdate() have a lot of
> commonality in their code. See about refactoring the common parts into
> AbstractYARNScheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
