[ 
https://issues.apache.org/jira/browse/YARN-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379209#comment-15379209
 ] 

Wilfred Spiegelenburg commented on YARN-5272:
---------------------------------------------

Sorry for the late reply. I ran into some DNS issues that took clusters down 
and have not paid attention to this one.

I would like to move the abstraction of the trim to a new jira. There is more 
trimming and splitting in the FairScheduler code that needs to be standardised 
and use utility methods.
The two points that we currently use it is split over two files and we probably 
want to introduce a new class FairSchedulerUtilities which has all these 
methods. Would you like me to log a new jira for it and make a start with the 
trim and split changes?

> Handle queue names consistently in FairScheduler
> ------------------------------------------------
>
>                 Key: YARN-5272
>                 URL: https://issues.apache.org/jira/browse/YARN-5272
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.8.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>         Attachments: YARN-5272.1.patch, YARN-5272.3.patch, YARN-5272.4.patch
>
>
> The fix used in YARN-3241 uses a the JDK trim() method to remove leading and 
> trailing spaces. The QueueMetrics uses a guava based trim when it splits the 
> queues.
> The guava based trim uses the unicode definition of a white space which is 
> different than the java trim as can be seen 
> [here|https://docs.google.com/a/cloudera.com/spreadsheets/d/1kq4ECwPjHX9B8QUCTPclgsDCXYaj7T-FlT4tB5q3ahk/pub]
> A queue name with a non-breaking white space will thus still cause the same 
> "Metrics source XXX already exists!" MetricsException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to