[ 
https://issues.apache.org/jira/browse/YARN-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381776#comment-15381776
 ] 

Rohith Sharma K S commented on YARN-1126:
-----------------------------------------

Thanks [~ywskycn] for re-base patch.

There are 2 nits. I think below nits are missed from previous patches while 
re-basing.
Test : 
# Add a validation for case insensitive all&ALL
# Add a validation for exit code when InvalidState is passed.

> Add validation of users input nodes-states options to nodes CLI
> ---------------------------------------------------------------
>
>                 Key: YARN-1126
>                 URL: https://issues.apache.org/jira/browse/YARN-1126
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-1126-002.patch, YARN-1126-003.patch, 
> YARN-1126-004.patch, YARN-905-addendum.patch
>
>
> Follow the discussion in YARN-905.
> (1) case-insensitive checks for "all".
> (2) validation of users input, exit with non-zero code and print all valid 
> states when user gives an invalid state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to