[ 
https://issues.apache.org/jira/browse/YARN-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated YARN-5057:
-----------------------------
    Attachment: YARN-5057.001.patch

There's a race in the test.  MockRM.finishAMAndVerifyAppState only waits until 
the app is in a completed state, but the delegation token renewer can still be 
processing an asynchronous event associated with that completion.  If the test 
tries to look at the renewer state before that event has been completely 
processed then tests can fail.

Here's a patch that changes each instance of MockRM.finishAMAndVerifyAppState 
in the test with a method that will do that and also wait for the specified 
token to stop being referenced by the application that is completing.

> resourcemanager.security.TestDelegationTokenRenewer fails in trunk
> ------------------------------------------------------------------
>
>                 Key: YARN-5057
>                 URL: https://issues.apache.org/jira/browse/YARN-5057
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>         Attachments: YARN-5057.001.patch
>
>
> The following test seems to fail easily if not always:
> {code}
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running 
> org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
> Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 42.996 sec 
> <<< FAILURE! - in 
> org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
> testCancelWithMultipleAppSubmissions(org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer)
>   Time elapsed: 0.382 sec  <<< FAILURE!
> java.lang.AssertionError: null
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertFalse(Assert.java:64)
>       at org.junit.Assert.assertFalse(Assert.java:74)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer.testCancelWithMultipleAppSubmissions(TestDelegationTokenRenewer.java:1134)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to