[
https://issues.apache.org/jira/browse/YARN-5307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387417#comment-15387417
]
Varun Vasudev commented on YARN-5307:
-------------------------------------
Thanks for the patch [~subru]! My thoughts -
1)
{code}
+ public FederationInsertNewApplicationResponse insertNewApplication(
+ FederationInsertNewApplicationRequest request) throws YarnException;
{code}
Rename insertNewApplication to addApplication
2)
{code}
+ public FederationApplicationInfo getApplicationInfo(ApplicationId appId)
+ throws YarnException;
{code}
Rename getApplicationInfo to getApplication
In addition, the function should return a GetApplicationResponse and accept
GetApplicationRequest
3)
{code}
+ public Map<ApplicationId, FederationApplicationInfo> getAllApplicationsInfo()
+ throws YarnException;
{code}
Rename getAllApplicationsInfo to getApplications. Like above, it should return
a GetApplicationsResponse and accept GetApplicationsRequest
4)
{code}
+ @Override
+ public int hashCode() {
+ return getApplicationId().hashCode();
+ }
{code}
In FederationApplicationInfo the hashCode function should take into account the
same params as the equals function.
> Federation Application State APIs
> ---------------------------------
>
> Key: YARN-5307
> URL: https://issues.apache.org/jira/browse/YARN-5307
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Subru Krishnan
> Attachments: YARN-5307-YARN-2915-v1.patch,
> YARN-5307-YARN-2915-v2.patch
>
>
> The Federation Application State encapsulates the mapping between an
> application and it's _home_ sub-cluster, i.e. the sub-cluster to which it is
> submitted to by the Router. Please refer to the design doc in parent JIRA for
> further details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
