[
https://issues.apache.org/jira/browse/YARN-5043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387449#comment-15387449
]
Sunil G commented on YARN-5043:
-------------------------------
Thanks [~hex108] for the patch, good catch.
If I understood you correctly, RMApp state is returned as FAILED, but still
statestore event processing may underway. So you want to ensure that ,
statestore events has to be processed before any RMApp state checks are done.
Am I correct?
About the patch, I am not very much in favor for having a {{resetDispatcher}}
from StateStore interface. I suggest you could have a mock statestore and
override dispatcher as {{DrainDispatcher}} and achieve the same. So we can
avoid extra reset api in RMStateStore. Thoughts?
> TestAMRestart.testRMAppAttemptFailuresValidityInterval random fail
> ------------------------------------------------------------------
>
> Key: YARN-5043
> URL: https://issues.apache.org/jira/browse/YARN-5043
> Project: Hadoop YARN
> Issue Type: Test
> Reporter: sandflee
> Assignee: Jun Gong
> Attachments: TestAMRestart-output.txt, YARN-5043.01.patch
>
>
> {noformat}
> Test set:
> org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.558 sec
> <<< FAILURE! - in
> org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
> testRMAppAttemptFailuresValidityInterval(org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart)
> Time elapsed: 31.509 sec <<< FAILURE!
> java.lang.AssertionError: expected:<2> but was:<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart.testRMAppAttemptFailuresValidityInterval(TestAMRestart.java:913)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
