[
https://issues.apache.org/jira/browse/YARN-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388615#comment-15388615
]
Young Chen commented on YARN-5324:
----------------------------------
Thanks [~curino],
Just a couple things I noticed when going through the patch:
- The second patch is missing the ProbabilisticRouterFederationPolicy, is this
intentional?
- In the first patch, in ProbabilisticRouterFederationPolicy there's this
section of code
{code:borderStyle=solid}
float totActiveWeight = 0;
for (FederationSubClusterId id : activeSubclusters.keySet()) {
totActiveWeight += weights.get(id);
}
{code}
If weights does not include all the sub clusters, or a newly active sub cluster
shows up in activeSubClusters, you can potentially have a nullptrexception here.
> Stateless router policies implementation
> ----------------------------------------
>
> Key: YARN-5324
> URL: https://issues.apache.org/jira/browse/YARN-5324
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Attachments: YARN-5324.01.patch, YARN-5324.02.patch
>
>
> These are policies at the Router that do not require maintaing state across
> choices (e.g., weighted random).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
