[ 
https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Suresh updated YARN-5392:
------------------------------
    Attachment: YARN-5392.007.patch

Thanks for the review [~leftnoteasy]

Updating the patch with you suggestions.
* There is only 1 create method now. (To create the key from the 
{{ResourceRequest}})
* I have added the schedulerKey to the RMContainerImpl, but I intentionally 
left the {{extractFrom()}} method (It is used only once... in the 
RMContainerImpl constructor.. to extract the key from the container before 
setting it in the RMContainerImpl)

I don't think I should remove the {{getLocalityWaitFactor}} and 
{{getTotalPendingRequests}} methods in this patch... [~sunilg] is planning on 
opening a cleanup patch, maybe we can make the changes there...



> Replace use of Priority in the Scheduling infrastructure with an opaque 
> ShedulerKey
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-5392
>                 URL: https://issues.apache.org/jira/browse/YARN-5392
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5392.001.patch, YARN-5392.002.patch, 
> YARN-5392.003.patch, YARN-5392.004.patch, YARN-5392.005.patch, 
> YARN-5392.006.patch, YARN-5392.007.patch
>
>
> Based on discussions in YARN-4888, this jira proposes to replace the use of 
> {{Priority}} in the Scheduler infrastructure (Scheduler, Queues, SchedulerApp 
> / Node etc.) with a more opaque and extensible {{SchedulerKey}}.
> Note: Even though {{SchedulerKey}} will be used by the internal scheduling 
> infrastructure, It will not be exposed to the Client or the AM. The 
> SchdulerKey is meant to be an internal construct that is derived from 
> attributes of the ResourceRequest / ApplicationSubmissionContext / Scheduler 
> Configuration etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to