[
https://issues.apache.org/jira/browse/YARN-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393865#comment-15393865
]
Shane Kumpf commented on YARN-5428:
-----------------------------------
After taking a harder looking, adding this to the DockerCommand constructor
will require passing in the Configuration to DockerCommand. This is not ideal
and therefore it was left up to the caller to add this property as needed. I
have updated the two places where DockerCommand is used to include the config
arg.
Regarding the checkstyle error, it appears that launchContainer was already at
the limit of 150 lines. It doesn't seem appropriate to fix this here and a new
issue could be opened to refactor launchContainer to get it under the line
limit.
The hadoop-yarn-api failure is because this is an optional configuration, with
no default value since the client already has a default (~/.docker). Updated
the test to ignore this property. The nodemanager failure looks to be unrelated
to this patch.
Uploading a new patch that addresses the failure and adds the appropriate calls
when the docker client config is needed.
> Allow for specifying the docker client configuration directory
> --------------------------------------------------------------
>
> Key: YARN-5428
> URL: https://issues.apache.org/jira/browse/YARN-5428
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-5428.001.patch
>
>
> The docker client allows for specifying a configuration directory that
> contains the docker client's configuration. It is common to store "docker
> login" credentials in this config, to avoid the need to docker login on each
> cluster member.
> By default the docker client config is $HOME/.docker/config.json on Linux.
> However, this does not work with the current container executor user
> switching and it may also be desirable to centralize this configuration
> beyond the single user's home directory.
> Note that the command line arg is for the configuration directory NOT the
> configuration file.
> This change will be needed to allow YARN to automatically pull images at
> localization time or within container executor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
