[
https://issues.apache.org/jira/browse/YARN-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396512#comment-15396512
]
Li Lu commented on YARN-5436:
-----------------------------
Thanks for the work [~aplusplus]! The {{FIXME}} part in AsyncDispatcher appears
to be confusing: There is no data race (per Java memory model's definition)
with the volatile variable {{drained}}. Maybe you'd like to rephrase a little
bit to express the potential nondeterminism?
Other changes in {{DrainedDispatcher}} appears to be fine to me.
> Race in AsyncDispatcher can cause random test failures in Tez(probably YARN
> also )
> ----------------------------------------------------------------------------------
>
> Key: YARN-5436
> URL: https://issues.apache.org/jira/browse/YARN-5436
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Zhiyuan Yang
> Assignee: Zhiyuan Yang
> Attachments: YARN-5436.1.patch, YARN-5436.2.patch
>
>
> In YARN-2264, a race in DrainDispatcher was fixed. Unfortunately, it also
> exists in AsyncDispatcher (this was found and ignored in YARN-3878 but never
> documented...). In YARN-2991, another DrainDispatcher bug was fixed by
> letting DrainDispatcher reuse some AsyncDispatcher method because
> AsyncDispatcher doesn't have such issue. However, this shadows YARN-2264, and
> now similar race reappears in Tez unit tests (probably also YARN unit tests
> also).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
