[
https://issues.apache.org/jira/browse/YARN-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396814#comment-15396814
]
Vinod Kumar Vavilapalli commented on YARN-3662:
-----------------------------------------------
Apologies for chiming in very late. I have more suggestions, please cherry-pick
things that you agree with are easy and feel free to defer the harder ones to
later JIRAs
- Drop *Federation* everywhere in the records? Instead, we can simply say
SubClusterInfoProto, SubClusterIdProto etc.
- None of these classes should be marked {{@Public}}.
- GetFederationSubClusterRequest -> GetSubClusterInfoRequest, similarly
response? Similarly the GetSubClustersRequest / response objects? Also, should
they be returning the info objects?
- HeartbeatFederationSubClusterRequest -> SubClusterHeartbeatRequest.
Similarly the response? Trying to follow NodeHeartbeat* records.
- Enums under FederationSubClusterState can afford not having the SC_ prefix -
the enum class is enough to distinguish them.. Again trying to follow other
enums in YARN.
> Federation Membership State Store internal APIs
> -----------------------------------------------
>
> Key: YARN-3662
> URL: https://issues.apache.org/jira/browse/YARN-3662
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Subru Krishnan
> Attachments: YARN-3662-YARN-2915-v1.1.patch,
> YARN-3662-YARN-2915-v1.patch, YARN-3662-YARN-2915-v2.patch,
> YARN-3662-YARN-2915-v3.01.patch, YARN-3662-YARN-2915-v3.patch,
> YARN-3662-YARN-2915-v4.patch, YARN-3662-YARN-2915-v5.patch
>
>
> The Federation Application State encapsulates the information about the
> active RM of each sub-cluster that is participating in Federation. The
> information includes addresses for ClientRM, ApplicationMaster and Admin
> services along with the sub_cluster _capability_ which is currently defined
> by *ClusterMetricsInfo*. Please refer to the design doc in parent JIRA for
> further details.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
