[
https://issues.apache.org/jira/browse/YARN-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398782#comment-15398782
]
Varun Vasudev edited comment on YARN-5443 at 7/29/16 6:16 AM:
--------------------------------------------------------------
Thanks for the patch [[email protected]]. Couple of changes -
1)
{code}
+ public static final String EXITED_STATUS = "exited";
+ public static final String RUNNING_STATUS = "running";
{code}
No need for these - they're not being used anywhere.
2)
Please rename DockerInspectCommandTest to TestDockerInspectCommand.
Also, I've noticed that DockerStopCommandTest has been committed to the code
base. That needs to be re-named to TestDockerStopCommand as well. We should
file a ticket to rename that class.
was (Author: vvasudev):
Thanks for the patch [[email protected]]. Couple of changes -
1)
{code}
+ public static final String EXITED_STATUS = "exited";
+ public static final String RUNNING_STATUS = "running";
{code}
No need for these - they're not being used anywhere.
2)
Please rename DockerInspectCommandTest to TestDockerInspectCommand.
Also, I've noticed that DockerStopCommandTest has been committed to the code
base. That needs to be re-named to TestDockerStopCommand as well.
> Add support for docker inspect
> ------------------------------
>
> Key: YARN-5443
> URL: https://issues.apache.org/jira/browse/YARN-5443
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-5443.001.patch
>
>
> Similar to the DockerStopCommand and DockerRunCommand, it would be desirable
> to have a DockerInspectCommand. The initial use is for retrieving a
> containers status, but many other uses are possible (IP information, volume
> information, etc).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
