[
https://issues.apache.org/jira/browse/YARN-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402843#comment-15402843
]
Junping Du commented on YARN-5226:
----------------------------------
Thanks [~xgong] for updating the patch. The patch looks good in overall.
Just a minor issue:
{noformat}
+ errorMessage.append(ex.getMessage() + "\n");
+ if (!conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED,
+ YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)) {
+ errorMessage.append("Please enable the timeline service "
+ + "and make sure the timeline server is running.");
+ } else {
+ if (request.isAppFinished()) {
{noformat}
I think it is better to check timeline service enabled under {{if
(request.isAppFinished())}}, otherwise, the message of failed to get
information for running apps could mess up with timeline service status. Isn't
it?
> remove AHS enable check from LogsCLI#fetchAMContainerLogs
> ---------------------------------------------------------
>
> Key: YARN-5226
> URL: https://issues.apache.org/jira/browse/YARN-5226
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-5226.1.patch, YARN-5226.2.patch, YARN-5226.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
