[ 
https://issues.apache.org/jira/browse/YARN-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403044#comment-15403044
 ] 

Subru Krishnan edited comment on YARN-4888 at 8/1/16 11:39 PM:
---------------------------------------------------------------

Thanks [~leftnoteasy] for reviewing the patch. I have updated (v6) it with your 
feedback.

I agree that the tests have commonality between _Capacity/Fair schedulers_ but 
I added them individually as YARN-4805 has disabled parameterized test 
execution. For e.g.: I did hit a minor bug in one of my early versions with FS 
which the current {{ParameterizedSchedulerTestBase}} will not capture but the 
existing tests in the patch will. 

Cc: [~kasha], what are your thoughts as I see you worked on YARN-4805 and you 
are aware of the changes here?


was (Author: subru):
Thanks [~leftnoteasy] for reviewing the patch. I have updated it with your 
feedback.

I agree that the tests have commonality between _Capacity/Fair schedulers_ but 
I added them individually as YARN-4805 has disabled parameterized test 
execution. For e.g.: I did hit a minor bug in one of my early versions with FS 
which the current {{ParameterizedSchedulerTestBase}} will not capture but the 
existing tests in the patch will. 

Cc: [~kasha], what are your thoughts as I see you worked on YARN-4805 and you 
are aware of the changes here?

> Changes in RM container allocation for identifying resource-requests 
> explicitly
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4888
>                 URL: https://issues.apache.org/jira/browse/YARN-4888
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>         Attachments: YARN-4888-WIP.patch, YARN-4888-v0.patch, 
> YARN-4888-v2.patch, YARN-4888-v3.patch, YARN-4888-v4.patch, 
> YARN-4888-v5.patch, YARN-4888-v6.patch, YARN-4888.001.patch
>
>
> YARN-4879 puts forward the notion of identifying allocate requests 
> explicitly. This JIRA is to track the changes in RM app scheduling data 
> structures to accomplish it. Please refer to the design doc in the parent 
> JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to