[
https://issues.apache.org/jira/browse/YARN-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404941#comment-15404941
]
Subru Krishnan commented on YARN-5406:
--------------------------------------
Thanks [~ellenfkh] for the patch and [~jianhe] for the review.
I have a few minor comments:
* I agree with [~jianhe] that the _impl_ package should be a sub-package of
the _store_ package.
* Rename {{FederationInMemoryMembershipStateStore}} -->
{{MemoryFederationStateStore}} and the corresponding test.
* We need to validate the inputs (like null checks). Since this is common
across different store implementations, I have created YARN-5467 to track this.
* All the tests are for positive cases, can we add a few for negative cases.
* I think we should add a _isSubClusterActive_ method to {{SubClusterState}}
and use it.
* Can you update the Javadoc for _FilterInactiveSubClusters_ as requested by
[~jianhe].
> In-memory based implementation of the FederationMembershipStateStore
> --------------------------------------------------------------------
>
> Key: YARN-5406
> URL: https://issues.apache.org/jira/browse/YARN-5406
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Ellen Hui
> Attachments: YARN-5406-YARN-2915.v0.patch
>
>
> YARN-3662 defines the FederationMembershipStateStore API. This JIRA tracks an
> in-memory based implementation which is useful for both single-box testing
> and for future unit tests that depend on the state store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
