[
https://issues.apache.org/jira/browse/YARN-5334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405821#comment-15405821
]
Sunil G commented on YARN-5334:
-------------------------------
Thanks [~Sreenath] for the patch and for working on same. Its really a nice
feature and helpful add-on while using the UI.
Few comments from my side:
1. In {{cluster-overview.js}} , I think we also need to unload *yarn-app* as it
will get fresh set of RUNNING apps.
2. Also in {{yarn-apps.js}}, we can unload *yarn-app*.
3. In {{yarn-nodes.js}}, we can unload *yarn-rm-node*
4. in {{yarn-queue-apps.js}}, we can unload *yarn-app*.
5. In {{yarn-queue.js}}, could we remove the unwanted console logs which prints
all items. Similarly in {{yarn-queues.js}}
6. {{<button type="button" class="btn btn-sm btn-primary refresh" action
"refresh">Refresh</button>}} if we can have custom button which can take
property like {{btn-sm btn-primary}}, it ll be helpful. Yes, we can remove
whole line in various templates, but its a big changes in all routes (for the
common action) and templates. We could come with an optimization and
improvement ticket later for same.
I also did an initial sanity tests. Looks good. Will do some more test and
update if I find some issues.
> [YARN-3368] Introduce REFRESH button in various UI pages
> --------------------------------------------------------
>
> Key: YARN-5334
> URL: https://issues.apache.org/jira/browse/YARN-5334
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: webapp
> Reporter: Sunil G
> Assignee: Sreenath Somarajapuram
> Attachments: YARN-5334-YARN-3368-0001.patch
>
>
> It will be better if we have a common Refresh button in all pages to get the
> latest information in all tables such as apps/nodes/queue etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
