[
https://issues.apache.org/jira/browse/YARN-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406820#comment-15406820
]
Subru Krishnan edited comment on YARN-5390 at 8/3/16 11:31 PM:
---------------------------------------------------------------
Thanks [~leftnoteasy] for reviewing the patch.
Thanks [~ellenfkh] for the patch. It mostly LGTM, just a couple of minor
comments:
* Can you add a *YARN_FEDERATION_PREFIX* in {{YarnConfiguration}} as we are
going to be using it a lot more in subsequent JIRAs.
* Please add findbugs exclusion for {{nodes}} and {{nodes-malformed}} test
resources.
* I feel the checkstyle warnings are not blockers but will good to fix if
it's easy to do so.
was (Author: subru):
Thanks [~leftnoteasy] for reviewing the patch.
It mostly LGTM, just a couple of minor comments:
* Can you add a *YARN_FEDERATION_PREFIX* in {{YarnConfiguration}} as we are
going to be using it a lot more in subsequent JIRAs.
* Please add findbugs exclusion for {{nodes}} and {{nodes-malformed}} test
resources.
* I feel the checkstyle warnings are not blockers but will good to fix if
it's easy to do so.
> Federation Subcluster Resolver
> ------------------------------
>
> Key: YARN-5390
> URL: https://issues.apache.org/jira/browse/YARN-5390
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Carlo Curino
> Assignee: Ellen Hui
> Attachments: YARN-5390-YARN-2915.v0.patch,
> YARN-5390-YARN-2915.v1.patch, YARN-5390-YARN-2915.v2.patch
>
>
> This JIRA tracks effort to create a mechanism to resolve nodes/racks resource
> names to sub-cluster identifiers. This is needed by the federation policies
> in YARN-5323, YARN-5324, YARN-5325 to operate correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
