[
https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407041#comment-15407041
]
Jun Gong commented on YARN-5333:
--------------------------------
Thanks [~rohithsharma] for the review.
bq. refreshXXXWithoutCheck does not looks meaning full method name. I think
common general pattern can be followed like below.
refreshXXXWithouCheck means that there is no check for refreshXXX. If
refreshXXX is acceptable, I'd like to change it.
bq. One of my major concern after seeing patch is skipping checkACL which used
to verify user for every transition-to-active. But now it is skipped.
I ignored it... It seems that we need add checkACL. How about adding it in
{{refreshAll}}?
{code}
refreshAll () {
checkACL("XXX");
refreshXXX();
...
}
{code}
bq. Test failure is related to patch change. I think this test can be removed
only since behavior is changed after this patch.
Yes, it is related, I fixed it in the patch 07.patch. The test case seems
useful for testing the case that {{refreshAll}} failed. Maybe we could keep it?
> Some recovered apps are put into default queue when RM HA
> ---------------------------------------------------------
>
> Key: YARN-5333
> URL: https://issues.apache.org/jira/browse/YARN-5333
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jun Gong
> Assignee: Jun Gong
> Attachments: YARN-5333.01.patch, YARN-5333.02.patch,
> YARN-5333.03.patch, YARN-5333.04.patch, YARN-5333.05.patch,
> YARN-5333.06.patch, YARN-5333.07.patch, YARN-5333.08.patch
>
>
> Enable RM HA and use FairScheduler,
> {{yarn.scheduler.fair.allow-undeclared-pools}} is set to false,
> {{yarn.scheduler.fair.user-as-default-queue}} is set to false.
> Reproduce steps:
> 1. Start two RMs.
> 2. After RMs are running, change both RM's file
> {{etc/hadoop/fair-scheduler.xml}}, then add some queues.
> 3. Submit some apps to the new added queues.
> 4. Stop the active RM, then the standby RM will transit to active and recover
> apps.
> However the new active RM will put recovered apps into default queue because
> it might have not loaded the new {{fair-scheduler.xml}}. We need call
> {{initScheduler}} before start active services or bring {{refreshAll()}} in
> front of {{rm.transitionToActive()}}. *It seems it is also important for
> other scheduler*.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
