[
https://issues.apache.org/jira/browse/YARN-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412043#comment-15412043
]
Daniel Templeton commented on YARN-5483:
----------------------------------------
Looks good to me. Looks like the call to {{pullJustFinishedContainers()}}
wasn't clearing the list of just finished containers per the method contract.
Nice catch.
With these lines:
{code}
finishedContainersSentToAM.putIfAbsent(nodeId,
new ArrayList<ContainerStatus>());
{code}
can you please use the diamond operator in the list constructor and merge them
back into one line?
> Optimize RMAppAttempt#pullJustFinishedContainers
> ------------------------------------------------
>
> Key: YARN-5483
> URL: https://issues.apache.org/jira/browse/YARN-5483
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: sandflee
> Assignee: sandflee
> Attachments: YARN-5483.01.patch, jprofiler-cpu.png
>
>
> about 1000 app running on cluster, jprofiler found pullJustFinishedContainers
> cost too much cpu.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
