[
https://issues.apache.org/jira/browse/YARN-5407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412813#comment-15412813
]
Subru Krishnan edited comment on YARN-5407 at 8/9/16 2:06 AM:
--------------------------------------------------------------
Thanks [~ellenfkh] for the patch.
I realized while reviewing this patch that {{SubClusterPolicyConfiguration}} is
missing *queue* field. Consequently we can remove it from
{{SetSubClusterPolicyConfigurationRequest}}. Can you kindly make the changes?
The patch itself LGTM. I have a minor suggestion for
{{FederationStateStoreBaseTest}} - we should have helper methods to add
applicationSubCluster mapping and policy similar to
_queryApplicationHomeSC/queryPolicy_ as they are used by all other tests and
now we have repeating code.
[~jianhe], can you take a quick look?
was (Author: subru):
Thanks [~ellenfkh] for the patch.
I realized while reviewing this patch that {{SubClusterPolicyConfiguration}} is
missing *queue* field. Consequently we can remove it from
{{SetSubClusterPolicyConfigurationRequest}}. Can you kindly make the changes?
It LGTM. I have a minor suggestion for {{FederationStateStoreBaseTest}} - we
should have helper methods to add applicationSubCluster mapping and policy
similar to _queryApplicationHomeSC/queryPolicy_ as they are used by all other
tests and now we have repeating code.
[~jianhe], can you take a quick look?
> In-memory based implementation of the FederationApplicationStateStore,
> FederationPolicyStateStore
> -------------------------------------------------------------------------------------------------
>
> Key: YARN-5407
> URL: https://issues.apache.org/jira/browse/YARN-5407
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Subru Krishnan
> Assignee: Ellen Hui
> Attachments: YARN-5407-YARN-2915.v0.patch,
> YARN-5407-YARN-2915.v1.patch
>
>
> YARN-5307 defines the FederationApplicationStateStore API. YARN-3664 defines
> the FederationPolicyStateStore API. This JIRA tracks an in-memory based
> implementation which is useful for both single-box testing and for future
> unit tests that depend on the state store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
