[ 
https://issues.apache.org/jira/browse/YARN-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413744#comment-15413744
 ] 

sandflee commented on YARN-5453:
--------------------------------

thanks for your explain, 
bq. the scheduler allows allocations over fairshare and hence over maxResources.
scheduler should grant that allocations should not exceed maxResource, seems 
unnecessary to limit demand to maxResource, thought?


> FairScheduler#update may skip update demand resource of child queue/app if 
> current demand reached maxResource
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5453
>                 URL: https://issues.apache.org/jira/browse/YARN-5453
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: sandflee
>            Assignee: sandflee
>         Attachments: YARN-5453.01.patch
>
>
> {code}
>       demand = Resources.createResource(0);
>       for (FSQueue childQueue : childQueues) {
>         childQueue.updateDemand();
>         Resource toAdd = childQueue.getDemand();
>         demand = Resources.add(demand, toAdd);
>         demand = Resources.componentwiseMin(demand, maxRes);
>         if (Resources.equals(demand, maxRes)) {
>           break;
>         }
>       }
> {code}
> if one singe queue's demand resource exceed maxRes,  the other queue's demand 
> resource will not update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to