[
https://issues.apache.org/jira/browse/YARN-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417918#comment-15417918
]
Joep Rottinghuis commented on YARN-4765:
----------------------------------------
Looks good to me.
One thing I'm wondering is if you're splitting the tests into apps and
entities, why not also split the DataGeneratorForTest into the two separate
parts? #loadApps and #loadEntities don't really have anything in common do they?
This isn't a strong requirement imho, either one is fine (given that is is one
giant class at the moment).
> Split TestHBaseTimelineStorage into multiple test classes
> ---------------------------------------------------------
>
> Key: YARN-4765
> URL: https://issues.apache.org/jira/browse/YARN-4765
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: YARN-5355
> Attachments: YARN-4765-YARN-5355.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
