[
https://issues.apache.org/jira/browse/YARN-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419741#comment-15419741
]
Subru Krishnan commented on YARN-5519:
--------------------------------------
Thanks [~ellenfkh] for the patch. It mostly looks good, couple of minor
comments:
* Add Javadocs for the getter/setter for new _subClusterId_ field in
{{AddApplicationHomeSubClusterResponse}}. Mention clearly that the
_subClusterId_ in response might be different from input in casing the mapping
already exists.
* The changes in
{{MemoryFederationStateStore::updateApplicationHomeSubCluster}} are redundant.
> Add SubClusterId in AddApplicationHomeSubClusterResponse for Router Failover
> ----------------------------------------------------------------------------
>
> Key: YARN-5519
> URL: https://issues.apache.org/jira/browse/YARN-5519
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Giovanni Matteo Fumarola
> Assignee: Ellen Hui
> Attachments: YARN-5519-YARN-2915.v1.patch
>
>
> This JIRA tracks the addition of SubClusterId into
> AddApplicationHomeSubClusterResponse.
> in the design of [YARN-3659|https://issues.apache.org/jira/browse/YARN-3659],
> to handle better fail-over scenario the response needs SubclusterId as field.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
