[ 
https://issues.apache.org/jira/browse/YARN-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429775#comment-15429775
 ] 

Arun Suresh commented on YARN-5049:
-----------------------------------

Thanks for brining this up [~jlowe]..
I am now wondering what the criteria is for updating the major and minor 
version number of the {{NMLevelDBStateStore}}.
This particular patch adds a new key suffix */queued* to the state store. Thus, 
the schema has changed but the old schema is still readable by the new version 
of NM. But roll back of the NM to the old version will not be possible (if it 
has queued atleast 1 container the container is in the queued at the time of 
the rollback)
Given the above, I feel this warrants just a minor version (instead of a major 
version update which is what this patch included), in which case the exception 
you specified will not be thrown (since minor versions are compatible).
If you agree, I can update the patch (or create a new JIRA) to just modify the 
minor version, and everything should be fine... else I will revert the patch 
from branch-2 until we have a migration script.


> Extend NMStateStore to save queued container information
> --------------------------------------------------------
>
>                 Key: YARN-5049
>                 URL: https://issues.apache.org/jira/browse/YARN-5049
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>             Fix For: 2.9.0
>
>         Attachments: YARN-5049.001.patch, YARN-5049.002.patch, 
> YARN-5049.003.patch
>
>
> This JIRA is about extending the NMStateStore to save queued container 
> information whenever a new container is added to the NM queue. 
> It also removes the information from the state store when the queued 
> container starts its execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to