[
https://issues.apache.org/jira/browse/YARN-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430786#comment-15430786
]
Sunil G edited comment on YARN-4849 at 8/22/16 1:51 PM:
--------------------------------------------------------
License patch looks fine for me.
I have few comments on doc patch:
1.
{{If you run RM locally in you computer just for test purpose, you need the
following things properly installed.}}
==> If you run RM locally in your computer for test purpose, you need the
following things properly installed.
2.
{noformat}
- Install Node.js with NPM: https://nodejs.org/download/
- After Node.js installed, install bower: `npm install -g corsproxy`.
{noformat}
This is to be changed to `npm install -g bower`
3. Since we are mentioned about corsproxy, we also need to give steps to
install corsproxy too.
was (Author: sunilg):
License patch looks fine for me.
I have few comments on doc patch:
1.
{{If you run RM locally in you computer just for test purpose, you need the
following things properly installed.}}
==> If you run RM locally in your computer for test purpose, you need the
following things properly installed.
2.
{noformat}]
- Install Node.js with NPM: https://nodejs.org/download/
- After Node.js installed, install bower: `npm install -g corsproxy`.
{nofromat}
This is to be changed to `npm install -g bower`
3. Since we are mentioned about corsproxy, we also need to give steps to
install corsproxy too.
> [YARN-3368] cleanup code base, integrate web UI related build to mvn, and fix
> licenses.
> ---------------------------------------------------------------------------------------
>
> Key: YARN-4849
> URL: https://issues.apache.org/jira/browse/YARN-4849
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Fix For: YARN-3368
>
> Attachments: YARN-4849-YARN-3368.1.patch,
> YARN-4849-YARN-3368.2.patch, YARN-4849-YARN-3368.3.patch,
> YARN-4849-YARN-3368.4.patch, YARN-4849-YARN-3368.5.patch,
> YARN-4849-YARN-3368.6.patch, YARN-4849-YARN-3368.7.patch,
> YARN-4849-YARN-3368.8.patch, YARN-4849-YARN-3368.addendum.1.patch,
> YARN-4849-YARN-3368.addendum.2.patch, YARN-4849-YARN-3368.addendum.3.patch,
> YARN-4849-YARN-3368.doc-fix-08172016.1.patch,
> YARN-4849-YARN-3368.license-fix-08172016.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
