[
https://issues.apache.org/jira/browse/YARN-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431395#comment-15431395
]
Min Shen commented on YARN-5543:
--------------------------------
[~leftnoteasy],
The existing test case for SchedulingMonitor tests if it can be successfully
initiated and started.
Do you think adding an additional unit test is necessary with this patch?
Also, for the test failure in
TestNodeBlacklistingOnAMFailures.testNodeBlacklistingOnAMFailure, it seems
irrelevant to this change.
Is this test case a known flaky one?
> ResourceManager SchedulingMonitor could potentially terminate the preemption
> checker thread
> -------------------------------------------------------------------------------------------
>
> Key: YARN-5543
> URL: https://issues.apache.org/jira/browse/YARN-5543
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacityscheduler, resourcemanager
> Affects Versions: 2.7.0, 2.6.1
> Reporter: Min Shen
> Attachments: YARN-5543.001.patch
>
>
> In SchedulingMonitor.java, when the service starts, it starts a checker
> thread to perform Capacity Scheduler's preemption. However, the
> implementation of this checker thread has the following issue:
> {code}
> while (!stopped && !Thread.currentThread().isInterrupted()) {
> ....
> try {
> Thread.sleep(monitorInterval)
> } catch (InterruptedException e) {
> ....
> break;
> }
> }
> {code}
> The above code snippet will terminate the checker thread whenever it is
> interrupted.
> We noticed in our cluster that this could lead to CapacityScheduler's
> preemption disabled unexpectedly due to the checker thread getting terminated.
> We propose to use ScheduledExecutorService to improve the robustness of this
> part of the code to ensure the liveness of CapacityScheduler's preemption
> functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
