[ 
https://issues.apache.org/jira/browse/YARN-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433419#comment-15433419
 ] 

Varun Saxena commented on YARN-5537:
------------------------------------

Thanks [~bibinchundatt] for the patch. Analysis is correct.
The fix will work but I do see a lot of deterministic sleeps in the test. This 
however becomes necessary because there is no way to drain multiple dispatchers 
across multiple NMs' and RM in MiniYarnCluster.

For the extra sleeps we have added to fix the test, can we have them in a loop 
and exit whenever the values for increased and decreased containers have 
reached the required number or not OR after a fixed number of times, whichever 
is earlier. 
This would mean that test would not have sleep extra time if not required. Pls 
note this test passes more than it fails.



> Intermittent test failure of 
> TestAMRMClient#testAMRMClientWithContainerResourceChange
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-5537
>                 URL: https://issues.apache.org/jira/browse/YARN-5537
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Varun Saxena
>            Assignee: Bibin A Chundatt
>         Attachments: Failure.txt, Failure_allocate.txt, YARN-5537.0001.patch
>
>
> Refer to test report 
> https://builds.apache.org/job/PreCommit-YARN-Build/12692/testReport/
> {noformat}
> Running org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.018 sec 
> <<< FAILURE! - in org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
> testAMRMClientWithContainerResourceChange(org.apache.hadoop.yarn.client.api.impl.TestAMRMClient)
>   Time elapsed: 1.183 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<0> but was:<1>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at org.junit.Assert.assertEquals(Assert.java:542)
>       at 
> org.apache.hadoop.yarn.client.api.impl.TestAMRMClient.doContainerResourceChange(TestAMRMClient.java:1019)
>       at 
> org.apache.hadoop.yarn.client.api.impl.TestAMRMClient.testAMRMClientWithContainerResourceChange(TestAMRMClient.java:909)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to