[ 
https://issues.apache.org/jira/browse/YARN-5571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443134#comment-15443134
 ] 

Rohith Sharma K S commented on YARN-5571:
-----------------------------------------

I believe design is made keeping in mind that federation support. But debatably 
with rarest scenario, what is app-id/user-id/flowname/flowurnid are same!!! 
Here cluster-id would come into picture. One one thing guarantee is 
cluster-id/namespace will be different. In the REST endpoints I see that 
cluster-id is null. 
There is slight differentiation with in the output of below required I believe
# GET /ws/v2/timeline/clusters/\{cluster name\}/apps/\{app id\} : Query for an 
App-id for an specified cluster-name in pathParam. Here, queryParam is not 
useful right? 
# GET /ws/v2/timeline/apps/\{app id\} : Query for an app-id for ALL the cluster 
from storage.

I would appreciate if you can point out me any flow-diagram/sequence-diagram 
for storage if any. 

> [Atsv2] Query App REST endpoing need not to expose queryParams such 
> userId/flowname/flowrunid
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-5571
>                 URL: https://issues.apache.org/jira/browse/YARN-5571
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: timelinereader
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>
> Timeline reader provides REST end point for querying app with an URL {{GET 
> /ws/v2/timeline/apps/\{app id\}}} along with queryParam as an filter. But 
> queryParam such as {{userId/flowname/flowrunid}} not at useful for querying 
> an app with app-id. In YARN cluster, only one app-id will be exist though out 
> life time. So userId/flowname/flowrunid not at all useful for the app-id REST 
> empoint
> {noformat}
>   @GET
>   @Path("/apps/{appid}/")
>   @Produces(MediaType.APPLICATION_JSON)
>   public TimelineEntity getApp(
>       @Context HttpServletRequest req,
>       @Context HttpServletResponse res,
>       @PathParam("appid") String appId,
>       @QueryParam("flowname") String flowName,
>       @QueryParam("flowrunid") String flowRunId,
>       @QueryParam("userid") String userId,
>       @QueryParam("confstoretrieve") String confsToRetrieve,
>       @QueryParam("metricstoretrieve") String metricsToRetrieve,
>       @QueryParam("fields") String fields,
>       @QueryParam("metricslimit") String metricsLimit) {
>     return getApp(req, res, null, appId, flowName, flowRunId, userId,
>         confsToRetrieve, metricsToRetrieve, fields, metricsLimit);
>   }
> {noformat} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to