[ 
https://issues.apache.org/jira/browse/YARN-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444529#comment-15444529
 ] 

Jian He commented on YARN-3671:
-------------------------------

Thanks Subru for updating !
- Here, the scheduler is passed in via reference. If the RM switches to standby 
and then switches back to active, the scheduler object will be re-created and 
the reference will be updated in RMContext, but the reference here won't be 
updated, which cause the scheduler object here outdated?
{code}
  public FederationStateStoreHeartbeat(FederationStateStore stateStoreClient,
      ResourceScheduler scheduler, SubClusterId clusterId) {
    this.stateStoreService = stateStoreClient;
    this.subClusterId = clusterId;
    this.rs = scheduler;
{code}
- "state-store.heartbeat-interval":  how about 
"state-store.heartbeat-interval-secs"

> Integrate Federation services with ResourceManager
> --------------------------------------------------
>
>                 Key: YARN-3671
>                 URL: https://issues.apache.org/jira/browse/YARN-3671
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Subru Krishnan
>         Attachments: YARN-3671-YARN-2915-v1.patch, 
> YARN-3671-YARN-2915-v2.patch, YARN-3671-YARN-2915-v3.patch
>
>
> This JIRA proposes adding the ability to turn on Federation services like 
> StateStore, cluster membership heartbeat etc in the RM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to