[
https://issues.apache.org/jira/browse/YARN-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445751#comment-15445751
]
Shane Kumpf commented on YARN-5366:
-----------------------------------
The latest patch fixes the test failures. As previously mentioned, the
checkstyle error is related to the package length.
Regarding the patch, {{DockerLinuxContainerRuntime#signalContainer}} now
implements the logic called out above to properly handle reacquiring, stopping,
and removing docker containers. {{DockerContainerStatusHandler}} was added to
encompass the state of a docker container, such as running, stopped, exited,
etc. A new constructor was added to {{DockerLinuxContainerRuntime}} that allows
for injecting a {{DockerContainerStatusHandler}} for testing purposes. Common
docker operations were refactored into {{DockerCommandExecutor}} to make it
more consistent on how docker operations are performed, however, refactoring
all places where docker commands are called has not been completed. I will open
another issue to do that refactoring work.
So two additional issues should be opened. If others agree, I'll get these
opened.
* Remove package length from the checkstyle rules.
* Refactor existing code and tests to leverage {{DockerCommandExecutor}}
I believe this patch is ready for review.
> Add support for toggling the removal of completed and failed docker containers
> ------------------------------------------------------------------------------
>
> Key: YARN-5366
> URL: https://issues.apache.org/jira/browse/YARN-5366
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Attachments: YARN-5366.001.patch, YARN-5366.002.patch
>
>
> Currently, completed and failed docker containers are removed by
> container-executor. Add a job level environment variable to
> DockerLinuxContainerRuntime to allow the user to toggle whether they want the
> container deleted or not and remove the logic from container-executor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
