[
https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446717#comment-15446717
]
Zhe Zhang commented on YARN-5550:
---------------------------------
Thanks [~jhung] for taking on the work. Patch LGTM overall. A couple of very
minor nits:
# Can we move {{CONTAINER_PATTERN}} below the private variables?
# We can also consider using the {{VisibleForTesting}} annotation here
+1 pending above
> TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
> --------------------------------------------------------------------------
>
> Key: YARN-5550
> URL: https://issues.apache.org/jira/browse/YARN-5550
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.6.4
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Priority: Minor
> Attachments: YARN-5550.001.patch, YARN-5550.002.patch
>
>
> TestYarnCLI#testGetContainers hard codes expected output of getting list of
> containers via Yarn CLI. If the timestamp is shorter than the number of
> expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the
> assert will fail due to whitespace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
