[
https://issues.apache.org/jira/browse/YARN-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449735#comment-15449735
]
Ray Chiang commented on YARN-5567:
----------------------------------
One point of clarification. While this *is* an incompatible change, I was
debating about the "hardness" of it. It will break on broken health checking
scripts (assuming anyone is even using the feature). If we want to treat this
as a hard incompatibility, then I'd go with my earlier suggestion. In general,
I prefer being conservative along these lines.
If others are of the mind that this is a "softer" incompatibility, we could
keep it in branch-2.8.
Either way, I agree the documentation and Javadoc need to be updated to match.
I've filed YARN-5595 as a follow up.
> Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
> --------------------------------------------------------------------------
>
> Key: YARN-5567
> URL: https://issues.apache.org/jira/browse/YARN-5567
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Fix For: 2.8.1
>
> Attachments: YARN-5567.001.patch
>
>
> In case of FAILED_WITH_EXIT_CODE, health status should be false.
> {code}
> case FAILED_WITH_EXIT_CODE:
> setHealthStatus(true, "", now);
> break;
> {code}
> should be
> {code}
> case FAILED_WITH_EXIT_CODE:
> setHealthStatus(false, "", now);
> break;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
