[ 
https://issues.apache.org/jira/browse/YARN-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450294#comment-15450294
 ] 

Li Lu commented on YARN-5561:
-----------------------------

Thanks [~rohithsharma]! I took a deeper look into the patch. The overall 
approach LGTM. One concern I have is, shall we expose the semantics of 
"containers" and "appattempts" in timeline reader API level? To me, the 
timeline API is independent from the actual use cases: it merely provides 
concrete ways to retrieve timeline entities. Similar to the past AHS APIs, 
maybe we'd like to abstract a separate layer of APIs for YARN to read data from 
timeline service? Of course we can integrate the new "AHS REST API" layer in 
the timeline reader server, but code-wise shall we separate the new APIs from 
TimelineReaderWebService? 

BTW, I set this JIRA to be patch available so that Jenkins can find the patch 
and test it. If you want something otherwise please feel free to change it 
back. Thanks! 

> [Atsv2] : Support for ability to retrieve apps/app-attempt/containers and 
> entities via REST
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-5561
>                 URL: https://issues.apache.org/jira/browse/YARN-5561
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: YARN-5561.patch, YARN-5561.v0.patch
>
>
> ATSv2 model lacks retrieval of {{list-of-all-apps}}, 
> {{list-of-all-app-attempts}} and {{list-of-all-containers-per-attempt}} via 
> REST API's. And also it is required to know about all the entities in an 
> applications.
> It is pretty much highly required these URLs for Web  UI.
> New REST URL would be 
> # GET {{/ws/v2/timeline/apps}}
> # GET {{/ws/v2/timeline/apps/\{app-id\}/appattempts}}.
> # GET 
> {{/ws/v2/timeline/apps/\{app-id\}/appattempts/\{attempt-id\}/containers}}
> # GET {{/ws/v2/timeline/apps/\{app id\}/entities}} should display list of 
> entities that can be queried.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to