[
https://issues.apache.org/jira/browse/YARN-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453249#comment-15453249
]
Hadoop QA commented on YARN-5505:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
24s {color} | {color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s
{color} | {color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s {color} | {color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 31s
{color} | {color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} yarn-native-services passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 56s
{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
in yarn-native-services has 314 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 27s
{color} | {color:red} hadoop-yarn-slider-core in yarn-native-services failed.
{color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 24s {color}
| {color:red}
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core
generated 2 new + 34 unchanged - 2 fixed = 36 total (was 36) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 33s
{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core:
The patch generated 47 new + 1086 unchanged - 94 fixed = 1133 total (was 1180)
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 14s
{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
generated 7 new + 310 unchanged - 4 fixed = 317 total (was 314) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 27s
{color} | {color:red} hadoop-yarn-slider-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 27s
{color} | {color:green} hadoop-yarn-slider-core in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 19s
{color} | {color:red} The patch generated 10 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 20m 14s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs |
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
|
| | Load of known null value in
org.apache.slider.providers.ProviderUtils.localizeConfigFiles(ContainerLauncher,
String, String, ConfTreeOperations, Map, MapOperations, SliderFileSystem,
String) At ProviderUtils.java:in
org.apache.slider.providers.ProviderUtils.localizeConfigFiles(ContainerLauncher,
String, String, ConfTreeOperations, Map, MapOperations, SliderFileSystem,
String) At ProviderUtils.java:[line 608] |
| | Possible null pointer dereference of configValue in
org.apache.slider.providers.ProviderUtils.dereferenceAllConfigs(Map)
Dereferenced at ProviderUtils.java:configValue in
org.apache.slider.providers.ProviderUtils.dereferenceAllConfigs(Map)
Dereferenced at ProviderUtils.java:[line 872] |
| | org.apache.slider.providers.ProviderUtils.uploadResource(File,
SliderFileSystem, Path) calls Thread.sleep() with a lock held At
ProviderUtils.java:with a lock held At ProviderUtils.java:[line 526] |
| | org.apache.slider.providers.ProviderUtils.dereferenceAllConfigs(Map)
makes inefficient use of keySet iterator instead of entrySet iterator At
ProviderUtils.java:keySet iterator instead of entrySet iterator At
ProviderUtils.java:[line 850] |
| | Null passed for non-null parameter of new java.io.File(String) in
org.apache.slider.providers.docker.DockerProviderService.applyInitialRegistryDefinitions(URL,
ServiceRecord) Method invoked at DockerProviderService.java:of new
java.io.File(String) in
org.apache.slider.providers.docker.DockerProviderService.applyInitialRegistryDefinitions(URL,
ServiceRecord) Method invoked at DockerProviderService.java:[line 280] |
| |
org.apache.slider.providers.docker.DockerProviderService.applyInitialRegistryDefinitions(URL,
ServiceRecord) makes inefficient use of keySet iterator instead of entrySet
iterator At DockerProviderService.java:of keySet iterator instead of entrySet
iterator At DockerProviderService.java:[line 278] |
| |
org.apache.slider.providers.docker.DockerProviderService.publishConfigAndExportGroups(String,
String, String, String) makes inefficient use of keySet iterator instead of
entrySet iterator At DockerProviderService.java:inefficient use of keySet
iterator instead of entrySet iterator At DockerProviderService.java:[line 344]
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12826491/YARN-5505-yarn-native-services.002.patch
|
| JIRA Issue | YARN-5505 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle xml |
| uname | Linux 3680b3720052 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | yarn-native-services / d0eb0e7 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core-warnings.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
|
| javac |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.html
|
| javadoc |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
|
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/12974/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Create an agent-less docker provider in the native-services framework
> ---------------------------------------------------------------------
>
> Key: YARN-5505
> URL: https://issues.apache.org/jira/browse/YARN-5505
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-5505-yarn-native-services.001.patch,
> YARN-5505-yarn-native-services.002.patch
>
>
> The Slider AM has a pluggable portion called a provider. Currently the only
> provider implementation is the agent provider which contains the bulk of the
> agent-related Java code. We can implement a docker provider that does not use
> the agent and gets information it needs directly from the NM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
