[jira] [Commented] (YARN-5264) Use FSQueue to store queue-specific information

[Daniel Templeton (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453283#comment-15453283
 ] 

Daniel Templeton commented on YARN-5264:
----------------------------------------

Darn it, I found something I had missed before.  In {{createNewQueues()}}, you 
have:

{code}
       if (!i.hasNext() && (queueType != FSQueueType.PARENT)) {
         FSLeafQueue leafQueue = new FSLeafQueue(queueName, scheduler, parent);
         leafQueue.init();
         leafQueues.add(leafQueue);
         queue = leafQueue;
       } else {
         newParent = new FSParentQueue(queueName, scheduler, parent);
         newParent.init();
         queue = newParent;
       }
{code}

The {{init()}} calls should be pulled out of the _if_ and become 
{{queue.init()}}, e.g.

{code}
       if (!i.hasNext() && (queueType != FSQueueType.PARENT)) {
         FSLeafQueue leafQueue = new FSLeafQueue(queueName, scheduler, parent);
         leafQueues.add(leafQueue);
         queue = leafQueue;
       } else {
         queue = new FSParentQueue(queueName, scheduler, parent);
       }

       queue.init();
{code}


> Use FSQueue to store queue-specific information
> -----------------------------------------------
>
>                 Key: YARN-5264
>                 URL: https://issues.apache.org/jira/browse/YARN-5264
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-5264.001.patch, YARN-5264.002.patch, 
> YARN-5264.003.patch, YARN-5264.004.patch, YARN-5264.005.patch
>
>
> Use FSQueue to store queue-specific information instead of querying 
> AllocationConfiguration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org