[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453640#comment-15453640
]
Karthik Kambatla commented on YARN-4997:
----------------------------------------
Thanks for working on this, [~cassanada].
Few (mostly minor) comments on the latest patch:
# YarnAuthorizationProvider#destroy should be marked @VisibleForTesting.
# Noticed there is QueueACL is mapreduce code as well that can be dropped
altogether? e.g. mapred QueueManager, many parts (all of?) QueueACL etc. Can we
file a follow-up JIRA to drop all of that?
# AllocationFileLoaderService:
## getDefaultPermissions: don't need to specify type when creating an arraylist
for defaultPermissions.
## Listener is an interface. Don't need to specify visibility - public?
# FairScheduler
## onReload: Is there a need to lock the scheduler when setting permissions?
Would it be okay to limit the synchronized block to whatever was synchronized
before?
## Similarly, is there a reason to synchronize setQueueAcls?
## In setQueueAcls, we seem to initially set to default permissions and then
"overwrite" it with final permissions. Is the first one necessary? I quickly
looked at implementation of ConfiguredAuthorizationProvider, setPermission's
semantics appear to be somewhere between append and overwrite. If it is append,
may be we should change that name to addPermission?
> Update fair scheduler to use pluggable auth provider
> ----------------------------------------------------
>
> Key: YARN-4997
> URL: https://issues.apache.org/jira/browse/YARN-4997
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Daniel Templeton
> Assignee: Tao Jie
> Attachments: YARN-4997-001.patch, YARN-4997-002.patch,
> YARN-4997-003.patch, YARN-4997-004.patch, YARN-4997-005.patch,
> YARN-4997-006.patch, YARN-4997-007.patch
>
>
> Now that YARN-3100 has made the authorization pluggable, it should be
> supported by the fair scheduler. YARN-3100 only updated the capacity
> scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
