[
https://issues.apache.org/jira/browse/YARN-5576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456223#comment-15456223
]
Arun Suresh commented on YARN-5576:
-----------------------------------
Thanks for the patch [~jianhe]!
Couple of comments:
# We need to override the {{ContainerManagerImpl::localize()}} method in the
{{QueuingContainerManagerImpl}}. Re-localization should not be allowed if the
container is currently queued (not yet running)
# I only see entries added to {{ResourceSet::resourcesFailedToBeLocalized}}
set. Shouldnt we remove these once the AM is notified of the failure ? Also,
Shouldn't these be notified back to the AM ? or we are just relying on the
diagnostic string sent to the AM in the GetContainerStatus response to notify
the AM ?
# wondering if we should have another *RE_LOCALIZE_CONTAINER_RESOURCE* event in
the {{ResourceLocalizationService}} to distinguish from the localization needed
for container initialization and correspondingly send different events to the
Container. Or maybe for the timebeing, we should just rename
*INIT_CONTAINER_RESOURCE* to *LOCALIZE_CONTAINER_RESOURCE*.
# Nit : spurious change in the imports of {{ContainerImpl}} and
{{BaseAMRMProxyTest}}
> Core change to localize resource while container is running
> -----------------------------------------------------------
>
> Key: YARN-5576
> URL: https://issues.apache.org/jira/browse/YARN-5576
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-5576.1.patch, YARN-5576.2.patch, YARN-5576.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
