[
https://issues.apache.org/jira/browse/YARN-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470203#comment-15470203
]
Rohith Sharma K S commented on YARN-5586:
-----------------------------------------
Overall patch look fine, one doubt on the patch,
While cloning the resources, CPU/memory being directly set. Instead of that,
can it be set in loop only?
{code}
Resource ret = Resource.newInstance(0, 0);
188 ret.setMemorySize(res.getMemorySize());
189 ret.setVirtualCores(res.getVirtualCores());
190 for (Map.Entry<String, ResourceInformation> entry :
res.getResources()
191 .entrySet()) {
192 if (entry.getKey().equals(ResourceInformation.MEMORY_MB.getName())
193 ||
entry.getKey().equals(ResourceInformation.VCORES.getName())) {
194 continue;
195 }
{code}
> Update the Resources class to consider all resource types
> ---------------------------------------------------------
>
> Key: YARN-5586
> URL: https://issues.apache.org/jira/browse/YARN-5586
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-5586-YARN-3926.001.patch
>
>
> The Resources class provides a bunch of useful functions like clone, addTo,
> etc. These need to be updated to consider all resource types instead of just
> memory and cpu.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
