[
https://issues.apache.org/jira/browse/YARN-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470469#comment-15470469
]
Varun Saxena commented on YARN-5585:
------------------------------------
Thanks Rohith for the patch.
A single column value filter of CompareOp.LESS wont work.
This is because comparison will be lexicographic (as HBase BinaryComparator is
used)
Assume the intention here is to fetch DAG IDs'. DAG ID is of the form
dag_14567890123_0049_11. Now ideally dag_14567890123_0049_6 would be lesser
than dag_14567890123_0049_11 but when we use SingleColumnValueFilter with
BinaryComparator, dag_14567890123_0049_6 will be considered greater, which is
wrong.
Can you tell me the use case ? Listing all DAGs' or listing DAGs' within an app
? Or something else ? Typically how many DAGs' can there be per app ?
Based on that, solution can be thought of. Because till now I was thinking that
fromId was required for apps.
Moreover, a couple of nits:
* Single column value filter need not be wrapped inside another filter list.
* createSingleColValueFilters => createSingleColValueFilter
> [Atsv2] Add a new filter fromId in REST endpoints
> -------------------------------------------------
>
> Key: YARN-5585
> URL: https://issues.apache.org/jira/browse/YARN-5585
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: YARN-5585.v0.patch
>
>
> TimelineReader REST API's provides lot of filters to retrieve the
> applications. Along with those, it would be good to add new filter i.e fromId
> so that entities can be retrieved after the fromId.
> Example : If applications are stored database, app-1 app-2 ... app-10.
> *getApps?limit=5* gives app-1 to app-10. But to retrieve next 5 apps, it is
> difficult.
> So proposal is to have fromId in the filter like
> *getApps?limit=5&&fromId=app-5* which gives list of apps from app-6 to
> app-10.
> This is very useful for pagination in web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
