[
https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated YARN-4855:
------------------------------------
Attachment: YARN-4855.008.patch
Thanks for working on the review comments [~Tao Jie],
I have uploaded patch for following items :
# {{acceptNode}} was not fitting hence made it {{isNodeSame}}
# ??"./yarn rmadmin \-replaceLabelsOnNode"?? : sorry my bad, it was going wrong
when *--fail-on-unkown-nodes* followed with no args
# ??I will trying to refine here, if you know some best practices, please tell
me?? : Have corrected in the attached, Please take a look.
please verify whether my patch is fine.
> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
> Key: YARN-4855
> URL: https://issues.apache.org/jira/browse/YARN-4855
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Tao Jie
> Assignee: Tao Jie
> Priority: Minor
> Attachments: YARN-4855.001.patch, YARN-4855.002.patch,
> YARN-4855.003.patch, YARN-4855.004.patch, YARN-4855.005.patch,
> YARN-4855.006.patch, YARN-4855.007.patch, YARN-4855.008.patch
>
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode --fail-on-unkown-nodes
> "node1=label1"* , it would be denied if node is unknown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
