[
https://issues.apache.org/jira/browse/YARN-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486347#comment-15486347
]
Jian He commented on YARN-5602:
-------------------------------
few minor comments:
- why this ? {{// Capability and HeartBeat are not necessary to compare the
information}}
- FederationStateStoreException: are the getErrorCode and getErrorMsg methods
needed ? as they can be retrieved from getCode..
- FederationStateStoreUtils: some param name in the method comments are wrong,
e.g. LOG , errMsg
- should the Exception related class in an exception package, rather than util ?
> Utils for Federation State and Policy Store
> -------------------------------------------
>
> Key: YARN-5602
> URL: https://issues.apache.org/jira/browse/YARN-5602
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Giovanni Matteo Fumarola
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-5602-YARN-2915.v1.patch,
> YARN-5602-YARN-2915.v2.patch
>
>
> This JIRA tracks the creation of utils for Federation State and Policy Store
> such as Error Codes, Exceptions...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
