[ 
https://issues.apache.org/jira/browse/YARN-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486556#comment-15486556
 ] 

Naganarasimha G R commented on YARN-5567:
-----------------------------------------

bq. standardizing on a specific error code for "detected bad Node" vs "bad 
script"
I was thinking something in the same lines when i mentioned earlier ??"Should 
we think of some other state which could warn the admin about this(which is 
captured in webui/Rest)"?? 
If NM can inform Healthy/UnHealthy/HealthValidationError, And this can be sent 
across Heartbeat to RM and RM can capture the state of this NM to be other than 
Running and UnHealthy (a New state).  This can be displayed in the WebUI and 
also in the can be queried using {{./yarn node -list -state}}

> Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus
> --------------------------------------------------------------------------
>
>                 Key: YARN-5567
>                 URL: https://issues.apache.org/jira/browse/YARN-5567
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.8.0, 3.0.0-alpha1
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>             Fix For: 3.0.0-alpha1
>
>         Attachments: YARN-5567.001.patch
>
>
> In case of FAILED_WITH_EXIT_CODE, health status should be false.
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(true, "", now);
>         break;
> {code}
> should be 
> {code}
>       case FAILED_WITH_EXIT_CODE:
>         setHealthStatus(false, "", now);
>         break;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to