[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Suresh updated YARN-5620:
------------------------------
Attachment: YARN-5620.013.patch
[~jianhe], thanks for checking.. Please find updated patch (v013)...
bq. ReInitializationContext#resourceSet is never initialized with the pending
resources ?
fixed this.. looks like the test case was passing because the localization
request was fired from the resourceSet in the event.. so it did get localized.
bq. Also, the symlinks for the upgraded resources are not overridden correctly.
we probably need to change this to be a map of (symlink -> localizedPath)
Can you take a look at the changes to ResourceSet in the latest patch? The
_mergeWith_ function merges with upgraded resource set with the existing one
and creates a new ResourceSet. It takes care of overwriting the symlinks.
I changed the localizedResources map from <Path, List<Links>> to <Path,
Set<Links>> since it is easier to de-dup.. like you said, I kept the call chain
intact (we can handle in another JIRA) but converting it back to <Path,
List<Links>> for the callers. Also, this happens only once when container is
started and every upgrade.. so am guess it should be fine.
Also.. I pulled in a change from YARN-5637 here. Essentially, if the
LocalResourceTracker gets a REQUEST for a resource and if it already exists,
then it just ignores the request.. I modified it slightly to ensure that the
container receives Resource Localized message even if the resource exists since
re-initialization can be kicked off only after the container receives a
Resource Localized message for ALL its required resources,
> Core changes in NodeManager to support re-initialization of Containers with
> new launchContext
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-5620
> URL: https://issues.apache.org/jira/browse/YARN-5620
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5620.001.patch, YARN-5620.002.patch,
> YARN-5620.003.patch, YARN-5620.004.patch, YARN-5620.005.patch,
> YARN-5620.006.patch, YARN-5620.007.patch, YARN-5620.008.patch,
> YARN-5620.009.patch, YARN-5620.010.patch, YARN-5620.011.patch,
> YARN-5620.012.patch, YARN-5620.013.patch
>
>
> JIRA proposes to modify the ContainerManager (and other core classes) to
> support upgrade of a running container with a new {{ContainerLaunchContext}}
> as well as the ability to rollback the upgrade if the container is not able
> to restart using the new launch Context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
