[
https://issues.apache.org/jira/browse/YARN-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487659#comment-15487659
]
Jian He commented on YARN-5637:
-------------------------------
Thanks Arun, some comments:
- Do we need to do something for this condition ? else, it can be removed,
{code}
if (container.reInitContext == null) {
}
{code}
- In RollbackContainerTransition: the container.getResourceSet() will return
all resources including current and previous version. We should re-request only
the previous version's resources, rather than the union of both? we probably
need to maintain current and previous versions of (ContainerLaunchContext +
ResourceSet) ?
{code}
@Override
protected ResourceSet getReInitResourceSet(ContainerImpl
container, ContainerEvent event) {
return container.getResourceSet();
}
{code}
- I still have question on the commit API, how does AM use this API in practice
? one implication for this API is that we'll have to persiste the commit state
for NM recovery later on.
- Also, should the rollback API be always be able to rollback ?
- ContainerLaunchContext already has the ContainerRetryContext ? can we reuse
that retryContext?
{code}
public void upgradeContainer(ContainerId containerId,
ContainerLaunchContext upgradeLaunchContext, boolean autoCommit,
ContainerRetryContext retryFailureContext) throws YarnException {
{code}
- The ContainerImpl#ContainerRetryContext is not updated to new value on
upgrade.
- RetryFailureTranstion: it's a bit complicated.. is it possible to simplify
it something like below:
{code}
if (shouldRetry(exitCode, retryContext)) {
} else if (shouldRollback) {
} else {
// exit
}
{code}
> Changes in NodeManager to support Container upgrade and rollback/commit
> -----------------------------------------------------------------------
>
> Key: YARN-5637
> URL: https://issues.apache.org/jira/browse/YARN-5637
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5637.001.patch
>
>
> YARN-5620 added support for re-initialization of Containers using a new
> launch Context.
> This JIRA proposes to use the above feature to support upgrade and subsequent
> rollback or commit of the upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
